fix(types): contravariant generic default in ComponentOption #7369
+20
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
Fix bugs spotted in vuejs/vue-test-utils#317 (comment).
Some type theory shenanigans below:
This pull request allows assigning
ComponentOption
of a Vue subclass toComponent
. The problem is that we used to mark default vm type asVue
inComponent
. However, sinceComponentOption
is contravariant against vm typeV
. The default bound should not be the upper boundVue
, but the lower boundnever
.For a more concrete example, consider this usage:
Then, assigning option to
ComponentOption<Vue>
, we could in theory do unsafe operation:Though it is not how we really use Vue, type checker cannot know this. To workaround, we can mark
anotherOption
to have vm type asnever
.never
is the bottom type of any type, soComponentOption<never>
'screate
method can accept nothing, and thusly anycreate
method from subclass can satisfy accepting nothing semantic. In practical words, this means we promise that we never usecreated
like the way above.